From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
---|---|
To: | Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: add __attribute__((noreturn)) to suppress a waring |
Date: | 2011-01-24 06:32:51 |
Message-ID: | 4D3D1D13.3040509@enterprisedb.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 24.01.2011 03:42, Itagaki Takahiro wrote:
> I found the following warning with Fedora 14 / gcc 4.5.1.
> ----
> pg_backup_archiver.c: In function ‘_discoverArchiveFormat’:
> pg_backup_archiver.c:1736:11: warning: ‘fh’ may be used uninitialized
> in this function
> ----
> To suppress it, I'm thinking to add noreturn to die_horribly().
> Any objections? Another solution might be adding a dummy assignment
> after calls of die_horribly().
I added a dummy assignment, that's how we've handled this before in
pg_dump. I guess we could use noreturn, we already use it in pg_re_throw
function. But we also have a dummy exit(1) call in the PG_RE_THROW macro
for non-gcc compilers, so we might need to do that here too.
Thanks!
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Fujii Masao | 2011-01-24 07:00:02 | Re: Tracking latest timeline in standby mode |
Previous Message | Fujii Masao | 2011-01-24 05:38:06 | Re: pg_basebackup for streaming base backups |