From: | Euler Taveira de Oliveira <euler(at)timbira(dot)com> |
---|---|
To: | Andy Colson <andy(at)squeakycode(dot)net> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, pgsql-rrreviewers(at)postgresql(dot)org |
Subject: | Re: [HACKERS] reviewers needed! |
Date: | 2011-01-16 21:13:30 |
Message-ID: | 4D335F7A.7010906@timbira.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-rrreviewers |
Em 16-01-2011 16:30, Andy Colson escreveu:
> I reviewed a couple patched, and I added my review to the commitfest page.
>
> If I find a problem, its obvious I should mark the patch as "returned
> with feedback".
>
> But what if I'm happy with it? I'm not a hacker so cannot do C code
> review, should I leave it alone? Mark it as "ready for committer"?
>
Did you take a look at [1]? If your patch involves C code and you're not C
proficient then there must be another reviewer to give his/her opinion (of
course, the other person could be the committer). I wouldn't mark it "ready
for committer" instead leave it as is ("needs review"); just be sure to add
your comments in the commitfest app.
[1] http://wiki.postgresql.org/wiki/RRReviewers
--
Euler Taveira de Oliveira
http://www.timbira.com/
From | Date | Subject | |
---|---|---|---|
Next Message | Noah Misch | 2011-01-16 21:38:38 | Re: ALTER TYPE 0: Introduction; test cases |
Previous Message | Pavel Stehule | 2011-01-16 21:07:13 | Re: texteq/byteaeq: avoid detoast [REVIEW] |
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2011-01-16 22:10:49 | Re: [HACKERS] reviewers needed! |
Previous Message | Andy Colson | 2011-01-16 19:30:58 | Re: [HACKERS] reviewers needed! |