Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] reviewers needed!

From: Euler Taveira de Oliveira <euler(at)timbira(dot)com>
To: Andy Colson <andy(at)squeakycode(dot)net>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, pgsql-rrreviewers(at)postgresql(dot)org
Subject: Re: [HACKERS] reviewers needed!
Date: 2011-01-16 21:13:30
Message-ID: 4D335F7A.7010906@timbira.com (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-rrreviewers
Em 16-01-2011 16:30, Andy Colson escreveu:
> I reviewed a couple patched, and I added my review to the commitfest page.
>
> If I find a problem, its obvious I should mark the patch as "returned
> with feedback".
>
> But what if I'm happy with it? I'm not a hacker so cannot do C code
> review, should I leave it alone? Mark it as "ready for committer"?
>
Did you take a look at [1]? If your patch involves C code and you're not C 
proficient then there must be another reviewer to give his/her opinion (of 
course, the other person could be the committer). I wouldn't mark it "ready 
for committer" instead leave it as is ("needs review"); just be sure to add 
your comments in the commitfest app.


[1] http://wiki.postgresql.org/wiki/RRReviewers


-- 
   Euler Taveira de Oliveira
   http://www.timbira.com/

In response to

pgsql-hackers by date

Next:From: Noah MischDate: 2011-01-16 21:38:38
Subject: Re: ALTER TYPE 0: Introduction; test cases
Previous:From: Pavel StehuleDate: 2011-01-16 21:07:13
Subject: Re: texteq/byteaeq: avoid detoast [REVIEW]

pgsql-rrreviewers by date

Next:From: Robert HaasDate: 2011-01-16 22:10:49
Subject: Re: [HACKERS] reviewers needed!
Previous:From: Andy ColsonDate: 2011-01-16 19:30:58
Subject: Re: [HACKERS] reviewers needed!

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group