Re: [HACKERS] reviewers needed!

From: Andy Colson <andy(at)squeakycode(dot)net>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org, pgsql-rrreviewers(at)postgresql(dot)org
Subject: Re: [HACKERS] reviewers needed!
Date: 2011-01-16 19:30:58
Message-ID: 4D334772.9070709@squeakycode.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-rrreviewers


I reviewed a couple patched, and I added my review to the commitfest page.

If I find a problem, its obvious I should mark the patch as "returned with feedback".

But what if I'm happy with it? I'm not a hacker so cannot do C code review, should I leave it alone? Mark it as "ready for committer"?

I marked my two reviews as ready for committer, but I feel like I've overstepped my bounds.

-Andy

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Josh Berkus 2011-01-16 20:12:11 Re: What happened to open_sync_without_odirect?
Previous Message Tom Lane 2011-01-16 19:28:01 Re: Bug in pg_describe_object, patch v2

Browse pgsql-rrreviewers by date

  From Date Subject
Next Message Euler Taveira de Oliveira 2011-01-16 21:13:30 Re: [HACKERS] reviewers needed!
Previous Message Dimitri Fontaine 2011-01-15 11:31:21 Re: reviewers needed!