some comments rewording in recovery.conf.sample about SR

From: "Jehan-Guillaume (ioguix) de Rorthais" <ioguix(at)free(dot)fr>
To: pgsql-hackers(at)postgresql(dot)org
Subject: some comments rewording in recovery.conf.sample about SR
Date: 2011-01-07 12:22:00
Message-ID: 4D270568.60309@free.fr
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello Hackers,

I believe comments in the recovery.conf.sample are somehow confusing
about standby and SR:

# Edit this file to provide the parameters that PostgreSQL needs to
# perform an archive recovery of a database, or to act as a log-streaming
# replication standby.

It seems incomplete. It doesn't recover OR act as a log-streaming
replication standby. It can behave as a standby node without SR as well.

# When standby_mode is enabled, the PostgreSQL server will work as
# a standby. It tries to connect to the primary according to the
# connection settings primary_conninfo, and receives XLOG records
# continuously.

This one is quite unclear as well. We might think that once we are in
standby_mode we will be in SR. Again, we can use the standby_mode
without primary_conninfo. This parameter only allows to keep the cluster
in recovery, it doesn't imply to set up the SR.

# By default, a standby server keeps streaming XLOG records from the
# primary indefinitely.

Same story...

Please, find in attachment a proposal of rewording.

Comments ?

Regards,
- --
Jehan-Guillaume (ioguix) de Rorthais
www.dalibo.org

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk0nBWAACgkQxWGfaAgowiJRlACfcXwFiGr1LlYuAPjwnOLIvoHl
SEAAoJbtNqG4bk1+htYKd9KALKCv/wCt
=q/x/
-----END PGP SIGNATURE-----

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jehan-Guillaume (ioguix) de Rorthais 2011-01-07 12:23:17 Re: some comments rewording in recovery.conf.sample about SR
Previous Message Itagaki Takahiro 2011-01-07 11:42:23 pgsql: New system view pg_stat_replication displays activity of wal sen