Skip site navigation (1) Skip section navigation (2)

back branches vs. VS 2008

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: back branches vs. VS 2008
Date: 2011-01-03 17:15:06
Message-ID: 4D22041A.3070908@dunslane.net (view raw or flat)
Thread:
Lists: pgsql-hackers
The following patch allows me to build the 8.3 and 8.4 branches using 
Visual Studio 2008, once the build system is patched. But I don't really 
know why. HEAD and 9.0 build fine without it. But those branches 
branches fail with a complaint about IPPROTO_IPV6 being undefined.

The patch seems harmless enough. But I'd like to know why it's 
happening. Does anyone have a clue?

cheers

andrew

diff --git a/src/backend/libpq/pqcomm.c b/src/backend/libpq/pqcomm.c
index 06aece3..c1775ea 100644
--- a/src/backend/libpq/pqcomm.c
+++ b/src/backend/libpq/pqcomm.c
@@ -383,7 +383,7 @@ StreamServerPort(int family, char *hostName, 
unsigned short portNumber,
         }
  #endif

-#ifdef IPV6_V6ONLY
+#if defined(IPV6_V6ONLY) && defined(IPPROTO_IPV6)
         if (addr->ai_family == AF_INET6)
         {
             if (setsockopt(fd, IPPROTO_IPV6, IPV6_V6ONLY,


Responses

pgsql-hackers by date

Next:From: Magnus HaganderDate: 2011-01-03 17:43:08
Subject: Re: back branches vs. VS 2008
Previous:From: Robert HaasDate: 2011-01-03 17:09:32
Subject: Re: Re: new patch of MERGE (merge_204) & a question about duplicated ctid

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group