From: | Jan Urbański <wulczer(at)wulczer(dot)org> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, Shigeru HANADA <hanada(at)metrosystems(dot)co(dot)jp> |
Subject: | Re: autogenerating error code lists (was Re: [COMMITTERS] pgsql: Add foreign data wrapper error code values for SQL/MED.) |
Date: | 2010-12-26 20:09:50 |
Message-ID: | 4D17A10E.4040005@wulczer.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On 26/12/10 20:57, Tom Lane wrote:
> =?UTF-8?B?SmFuIFVyYmHFhHNraQ==?= <wulczer(at)wulczer(dot)org> writes:
>> How about a format like this then:
>
>> # Comment
>> Section: Class 2F - SQL Routine Exception
>> macro_name sqlstate plpgsqlname is_error
>
>> That is: # and blank lines are comments, lines starting with "Section:"
>> are section names (needed for SGML output), the rest are whitespace
>> separated strings. is_error is 0 or 1, if it's 0 we don't generate a
>> plpgsql condition for it.
>
> Or just leave out the plpgsqlname if we don't want a condition to be
> generated?
Makes sense. Wait, no, errcodes.sgml includes the entries for success
and warnings, but the plpgsql conditions list does not. So we need a
separate column to differentiate.
> Things might line up nicer if the sqlstate is the first column.
I was thinking of separating the values with tabs anyway, but I'm fine
with putting sqlstate first.
Cheers,
Jan
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2010-12-26 20:14:52 | Re: autogenerating error code lists (was Re: [COMMITTERS] pgsql: Add foreign data wrapper error code values for SQL/MED.) |
Previous Message | Tom Lane | 2010-12-26 19:57:26 | Re: autogenerating error code lists (was Re: [COMMITTERS] pgsql: Add foreign data wrapper error code values for SQL/MED.) |
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2010-12-26 20:14:52 | Re: autogenerating error code lists (was Re: [COMMITTERS] pgsql: Add foreign data wrapper error code values for SQL/MED.) |
Previous Message | Tom Lane | 2010-12-26 19:57:26 | Re: autogenerating error code lists (was Re: [COMMITTERS] pgsql: Add foreign data wrapper error code values for SQL/MED.) |