From: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
---|---|
To: | Vinicius Santos <vinicius(dot)santos(dot)lista(at)gmail(dot)com> |
Cc: | pgadmin-hackers(at)postgresql(dot)org |
Subject: | Re: "Clear window" in the SQL Editor |
Date: | 2010-12-06 11:34:14 |
Message-ID: | 4CFCCA36.5000308@lelarge.info |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Le 29/11/2010 23:35, Vinicius Santos a écrit :
> [...]
> In the SQL editor window, when the focus is outside of any text box, the
> button "clear window" does nothing.
>
> I believe that confuse the user. In this case the button should clear
> the SQL editor.
>
> Do you agree?
>
> I made this change.
>
> void frmQuery::OnClear(wxCommandEvent& ev)
> {
> wxWindow *wnd=currentControl();
>
> if (wnd == sqlQuery)
> sqlQuery->ClearAll();
> else if (wnd == msgResult)
> msgResult->Clear();
> else if (wnd == msgHistory)
> msgHistory->Clear();
> else if (wnd == scratchPad)
> scratchPad->Clear();
> + else
> + sqlQuery->ClearAll();
> }
>
>
> Sorry my bad English. I am Brazilian.
> The Google translator is helping me.
>
Sorry for not answering sooner, it seems a good change to me, I need to
check it first.
Thanks for your patch.
--
Guillaume
http://www.postgresql.fr
http://dalibo.com
From | Date | Subject | |
---|---|---|---|
Next Message | Guillaume Lelarge | 2010-12-07 07:33:41 | pgAdmin III commit: Fix typo in --no-privileges option of frmRestore |
Previous Message | Guillaume Lelarge | 2010-12-06 11:32:44 | Re: Ticket 283: Add option to request BOM write |