| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>, Joshua Tolley <eggyknap(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: pg_execute_from_file review |
| Date: | 2010-11-29 16:15:41 |
| Message-ID: | 4CF3D1AD.4080605@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11/29/2010 10:51 AM, Robert Haas wrote:
>>
>> I'm not sure why you need either "from". It just seems like a noise word.
>> Maybe we could use pg_execute_query_file() and pg_execute_query_string(),
>> which would be fairly clear and nicely symmetrical.
> Because you execute queries, not files. Or at least that's how I
> think about it.
>
Well, to me "pg_execute_query_file" says "execute the queries in this
file". I'm not sure what else it could sensibly mean. But I think any of
the suggestions will probably work OK.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joshua Tolley | 2010-11-29 16:18:13 | Re: pg_execute_from_file review |
| Previous Message | Tom Lane | 2010-11-29 16:12:58 | Re: pg_execute_from_file review |