| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>, Joshua Tolley <eggyknap(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: pg_execute_from_file review |
| Date: | 2010-11-29 15:37:32 |
| Message-ID: | 4CF3C8BC.4010605@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11/29/2010 10:30 AM, Robert Haas wrote:
> On Mon, Nov 29, 2010 at 10:27 AM, Robert Haas<robertmhaas(at)gmail(dot)com> wrote:
>> On Mon, Nov 29, 2010 at 4:26 AM, Dimitri Fontaine
>> <dimitri(at)2ndquadrant(dot)fr> wrote:
>>>> * I'd like to ask native speakers whether "from" is needed in names
>>>> of "pg_execute_from_file" and "pg_execute_from_query_string".
>>> Fair enough, will wait for some comments before producing a v6.
>> Yes, you need the from there.
> Eh, wait. You definitely need from in pg_execute_from_file(). But
> pg_execute_from_query_string() doesn't sound quite right. What does
> that function do, anyway?
I'm not sure why you need either "from". It just seems like a noise
word. Maybe we could use pg_execute_query_file() and
pg_execute_query_string(), which would be fairly clear and nicely
symmetrical.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dimitri Fontaine | 2010-11-29 15:42:10 | Re: pg_execute_from_file review |
| Previous Message | Tom Lane | 2010-11-29 15:34:40 | Re: Report: Linux huge pages with Postgres |