Skip site navigation (1) Skip section navigation (2)

Re: why does plperl cache functions using just a bool for is_trigger

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Jan Urbański <wulczer(at)wulczer(dot)org>, Postgres - Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: why does plperl cache functions using just a bool for is_trigger
Date: 2010-10-31 18:00:41
Message-ID: 4CCDAEC9.6030504@dunslane.net (view raw or flat)
Thread:
Lists: pgsql-hackers

On 10/31/2010 11:44 AM, Tom Lane wrote:
> =?UTF-8?B?SmFuIFVyYmHFhHNraQ==?=<wulczer(at)wulczer(dot)org>  writes:
>> Seems that this circumverts some output conversion error checking, since
>> adding the attached to the regression suite results in a segfault during
>> the plperl installcheck.
>> Reverting 2d01ec0708d571eef926f3f5795aa73759df5d9a fixes it.
> Good catch, patch reverted (and regression test added).

Well, I guess that answers the question of why we needed it, which 
nobody could answer before. I'm not sure I exactly understand what's 
going on here, though - I guess I need to look at it closer. At least I 
think we need a code comment on why the trigger flag is needed as part 
of the hash key.

cheers

andrew

In response to

Responses

pgsql-hackers by date

Next:From: Dimitri FontaineDate: 2010-10-31 18:19:08
Subject: Re: ALTER OBJECT any_name SET SCHEMA name
Previous:From: Heikki LinnakangasDate: 2010-10-31 17:46:31
Subject: Re: ALTER OBJECT any_name SET SCHEMA name

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group