Skip site navigation (1) Skip section navigation (2)

Re: Database selector

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Erwin Brandstetter <brsaweda(at)gmail(dot)com>
Cc: pgadmin-support(at)postgresql(dot)org, Josh Berkus <josh(at)agliodbs(dot)com>, Dave Page <dpage(at)pgadmin(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net>
Subject: Re: Database selector
Date: 2010-10-28 04:25:48
Message-ID: 4CC8FB4C.4000307@lelarge.info (view raw or flat)
Thread:
Lists: pgadmin-support
Le 27/10/2010 10:12, Erwin Brandstetter a écrit :
> On 27.10.2010 17:51, Guillaume Lelarge wrote:
>> Le 26/10/2010 17:11, Erwin Brandstetter a écrit :
>>> On Oct 22, 8:45 pm, dp(dot)(dot)(dot)(at)pgadmin(dot)org (Dave Page) wrote:
>>>> On Fri, Oct 22, 2010 at 7:42 PM, Josh Berkus<j(dot)(dot)(dot)(at)agliodbs(dot)com>  wrote:
>>>> (...)
>>>>> OK.  I don't think it's as valuable as other stuff people could be
>>>>> working on.  Like fixing the database selector, for example.  ;-)
>>>> I thought Guillaume had fixed it. Is it still borked?
>>> If you talk about ticket #232 "Smart defaults for new connection in
>>> query tool" I may be able to shed some light on that as I brought that
>>> up in the first place.
>>> Guillaume wrote a fix, and it looks good, but for an unknown reason it
>>> has been reserved for v1.14. (It certainly is not in the current
>>> version.)
>> I commited it only on the master branch because this is not a bugfix.
>> It's a new behaviour on something that works, hence it's in the dev
>> branch.
> 
> As far as I am concerned, it would be welcome as bugfix in 1.12, as the
> present behaviour is a nuisance. Given there wasn't some
> misunderstanding, Josh felt the same way.
> But your mileage may vary ...
> 

Dave, Magnus, any opinion on this?

It sure isn't a lot of code, and one can think it is a bugfix. Not
really my opinion, but I don't object to apply it on 1.12.

FYI:
  http://code.pgadmin.org/trac/ticket/232

http://github.com/gleu/pgadmin3/commit/8c358a7ead668bc7b2f7c845ab83b4b3c8f4d1aa


-- 
Guillaume
 http://www.postgresql.fr
 http://dalibo.com

In response to

Responses

pgadmin-support by date

Next:From: Dave PageDate: 2010-10-28 07:33:09
Subject: Re: Database selector
Previous:From: Erwin BrandstetterDate: 2010-10-27 17:12:10
Subject: Re: Database selector

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group