Skip site navigation (1) Skip section navigation (2)

Re: #229

From: Steffen Kuhn <pg(at)kuhnsteffen(dot)de>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: #229
Date: 2010-09-23 19:11:42
Message-ID: 4C9BA66E.6070608@kuhnsteffen.de (view raw or flat)
Thread:
Lists: pgadmin-hackers
Hi Guillaume,

actually I wanted to tooltip 'De-/Select all ...' ;-)
My intension was do bring the benefit with less code, logic and 
dependencies,
but anyway if it feels not good here the next try.

Added some pixel-pimped images - just have a look at.

Regards Steffen

Am 20.09.2010 22:34, schrieb Guillaume Lelarge:
> Le 18/09/2010 06:57, Steffen Kuhn a écrit :
>    
>> Hi Gullaime,
>>
>> please find patch for #229 attached.
>>
>>      
> Patch seems fine. I think the icon should get changed when the action
> changes. I mean, you click on the button, everything is selected and I
> kind of expected that the icon would changed too (with an unselect
> icon). It's a bit nitty-picky, but I think it's worth it.
>
> Anyway, even if the icon doesn't change, the tooltip should get changed.
>
> Both of them should be easy to do. Will commit as soon as this is fixed.
>
> Thanks for your work.
>
>
>    


Attachment: pixel.pimp.tar.gz
Description: application/x-gzip (8.6 KB)
Attachment: uncheck.xpm
Description: image/x-xpixmap (1.6 KB)
Attachment: #229.work.patch
Description: text/x-patch (11.2 KB)

In response to

  • Re: #229 at 2010-09-20 20:34:38 from Guillaume Lelarge

Responses

  • Re: #229 at 2010-10-06 20:15:11 from Guillaume Lelarge

pgadmin-hackers by date

Next:From: gitDate: 2010-09-23 20:12:34
Subject: pgAdmin III commit: Branch refs/heads/mybugfixwork was created
Previous:From: pgAdmin TracDate: 2010-09-23 18:08:06
Subject: Re: [pgAdmin III] #238: pgAdmin 1.12.0 crashes when displaying properties panel

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group