Re: Query history mystery box

Le 21/09/2010 22:44, Thom Brown a écrit :
> On 21 September 2010 21:40, Guillaume Lelarge <guillaume(at)lelarge(dot)info> wrote:
>> Le 21/09/2010 22:05, Guillaume Lelarge a écrit :
>>> Le 21/09/2010 14:37, Thom Brown a écrit :
>>>> On 21 September 2010 13:31, Guillaume Lelarge <guillaume(at)lelarge(dot)info> wrote:
>>>>> Le 21/09/2010 14:25, Thom Brown a écrit :
>>>>>> Hi all,
>>>>>>
>>>>>> I think the query history box should be labelled, or at least have a
>>>>>> tooltip. A colleague of mine was confused by the presence of the new
>>>>>> drop-down box with no indication as to what this was. And to make
>>>>>> matters worse, when he went to the help guide, the screenshot doesn't
>>>>>> show this drop-down.
>>>>>>
>>>>>
>>>>> The documentation is not good. We need to work on that for next release.
>>>>> One of the issues we are facing is the format we should use. Right now,
>>>>> every thing is a mixed of PHP and HTML, which is great for translation,
>>>>> but bad if we want to find writers that aren't coders too.
>>>>>
>>>>> But before that, updating some screenshots would be a pretty good idea.
>>>>> Everyone is welcomed to contribute this way.
>>>>>
>>>>>> Could it be made clearer what the function of this box is. Like
>>>>>> "Previous queries" or "Statement history". And update the help to
>>>>>> show this with an explaination as to its function?
>>>>>>
>>>>>
>>>>> Could be done, yeah. If you think it's much better for the user, that's
>>>>> something quite easy and quick to do.
>>>>
>>>> Yes, I think it's pretty much essential as otherwise it leaves the
>>>> user to guess as to its function. Another idea is for it to say
>>>> "Select From Statement History" as the default entry (if there is a
>>>> history to select from), and whatever the user selects from the
>>>> history overwrite this.
>>>>
>>>
>>> Nope. Attached is a patch that adds a tooltip...
>>>
>>>> And it appears the user can type stuff into this field too. Shouldn't
>>>> that be non-editable?
>>>>
>>>
>>> ... and makes the combobox read-only.
>>>
>>> I'm gonna work on another patch to add a label, but it will be for the
>>> next release.
>>>
>>
>> See the screenshot attached. Seems good to you?
>>
>> Patch attached.
>
> That's perfect! Yes, I think that'll make its function clear.
>

Both commited.

> Thanks Guillaume. :)
>

You're welcome.

--
Guillaume
http://www.postgresql.fr
http://dalibo.com