Skip site navigation (1) Skip section navigation (2)

Re: "serializable" in comments and names

From: "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
To: "Robert Haas" <robertmhaas(at)gmail(dot)com>
Cc: "Dan Ports" <drkp(at)csail(dot)mit(dot)edu>, "<pgsql-hackers(at)postgresql(dot)org>" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: "serializable" in comments and names
Date: 2010-09-02 18:23:37
Message-ID: 4C7FA559020000250003508C@gw.wicourts.gov (view raw or flat)
Thread:
Lists: pgsql-hackers
Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
 
> The current definition is:
> 
> #define IsXactIsoLevelSerializable (XactIsoLevel >=
> XACT_REPEATABLE_READ)
> 
> ...which is certainly a bit odd, since you'd think it would be
> comparing against XACT_SERIALIZABLE given the name.
 
Precisely why I want to rename it.  ;-)
 
> IsXactIsoLevelRepeatableRead()?
 
Since the SSI implementation of a fully serializable transaction
isolation level needs to do everything that the snapshot isolation
of REPEATABLE READ does, plus a wee bit more, it is convenient to
have a macro with the same semantics; just a less confusing name.
I don't see anywhere in the code where there's a need to test for
*just* REPEATABLE READ -- anything done for that also needs to be
done for SERIALIZABLE.
 
> XactUsesPerXactSnapshot()?
 
That seems unambiguous.  I think I prefer it to
IsXactIsoLevelXactSnapshotBased, so if there are no objections, I'll
switch to XactUsesPerXactSnapshot.  The current code uses a macro
without parentheses; are you suggesting that the new code add those?
 
> Or, inverting the sense of it, XactUsesPerStatementSnapshot()?
 
I don't see anywhere that the code is throwing an exclamation point
in front of the macro name, so inverting it seems like a bad idea. 
I'd rather go from:
 
    if (IsXactIsoLevelSerializable)
 
to:
 
    if (XactUsesPerXactSnapshot)
 
than:
 
    if (!XactUsesPerStatementSnapshot)
 
Given the suggested name above, IsXactIsoLevelFullySerializable no
longer seems, well, symmetrical.  How do you feel about
XactIsFullySerializable?
 
Names starting with IsXactIsoLevel seem more technically correct,
but the names get long enough that it seems to me that the meaning
gets a bit lost in the jumble of words -- which is why I like the
shorter suggested name.  Any other opinions out there?
 
-Kevin

In response to

Responses

pgsql-hackers by date

Next:From: Heikki LinnakangasDate: 2010-09-02 18:30:59
Subject: Re: Interruptible sleeps (was Re: CommitFest 2009-07: Yay, Kevin! Thanks, reviewers!)
Previous:From: Robert HaasDate: 2010-09-02 17:55:31
Subject: Re: "serializable" in comments and names

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group