Skip site navigation (1) Skip section navigation (2)

Re: refactoring comment.c

From: "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
To: "Robert Haas" <robertmhaas(at)gmail(dot)com>, "Peter Eisentraut" <peter_e(at)gmx(dot)net>
Cc: "pgsql-hackers" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: refactoring comment.c
Date: 2010-08-27 21:35:13
Message-ID: 4C77E9410200002500034D8E@gw.wicourts.gov (view raw or flat)
Thread:
Lists: pgsql-hackers
Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
 
> I suppose this is unhappy because it things elog(ERROR) might
> return?
 
It looks more like this code uses it without initialization:
 
        case OBJECT_INDEX:
        case OBJECT_SEQUENCE:
        case OBJECT_TABLE:
        case OBJECT_VIEW:
            relation =
                get_relation_by_qualified_name(objtype, objname,
lockmode);
            address.classId = RelationRelationId;
            address.objectId = RelationGetRelid(relation);
            address.objectSubId = 0;
            break;
 
-Kevin

In response to

Responses

pgsql-hackers by date

Next:From: Robert HaasDate: 2010-08-27 21:38:07
Subject: Re: refactoring comment.c
Previous:From: Robert HaasDate: 2010-08-27 21:28:05
Subject: Re: refactoring comment.c

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group