Skip site navigation (1) Skip section navigation (2)

Re: Issue with libpq < 8.4

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Dave Page <dpage(at)pgadmin(dot)org>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Issue with libpq < 8.4
Date: 2010-08-26 09:48:20
Message-ID: 4C763864.3090401@lelarge.info (view raw or flat)
Thread:
Lists: pgadmin-hackers
Le 24/08/2010 15:25, Magnus Hagander a écrit :
> On Tue, Aug 24, 2010 at 2:23 PM, Guillaume Lelarge
> <guillaume(at)lelarge(dot)info> wrote:
>> Le 24/08/2010 14:05, Magnus Hagander a écrit :
>>> On Tue, Aug 24, 2010 at 2:01 PM, Guillaume Lelarge
>>> <guillaume(at)lelarge(dot)info> wrote:
>>>> Le 24/08/2010 13:51, Dave Page a écrit :
>>>>> On Tue, Aug 24, 2010 at 12:48 PM, Magnus Hagander <magnus(at)hagander(dot)net>
>>>>> wrote:
>>>>>> Actually, what happens if we try to use PQconnect() with
>>>>>> applicaiton_name on an older version? I assume it fails, and not just
>>>>>> works and ignores it?
>>>>>
>>>>> iirc, yes.
>>>>>
>>>>
>>>> We have this in the log:
>>>>
>>>> FATAL:  unrecognized configuration parameter "application_name"
>>>>
>>>> And then it connects.
>>>>
>>>> At least with a 9.0 libpq and a 8.3.0 PostgreSQL server.
>>>
>>> Yeah, the interesting thing would be an 8.3 libpq, if you just throw
>>> it the connection string and don't try to use PQparseconnInfo().
>>>
>>
>> It fails. If the user has a 8.3 libpq, we should not send the
>> application_name connection parameter.
> 
> That means Dave is perfectly correct, and thus someone needs to write
> that patch ;)
> 

What I've come to is this patch. Actually, and quite surprisingly, it
doesn't work. I have no idea why. The configure script finds if we have
or not the PQconninfoParse function(), but the #ifdef in pgConn source
file doesn't seem to do what it has to. I always get a build without
PQconninfoParse, wether configure founds it or not.

Any ideas on what I did wrong?


-- 
Guillaume
 http://www.postgresql.fr
 http://dalibo.com

In response to

Responses

pgadmin-hackers by date

Next:From: Dave PageDate: 2010-08-26 09:49:13
Subject: Re: Issue with libpq < 8.4
Previous:From: Dave PageDate: 2010-08-26 09:20:07
Subject: Re: pgAdmin III commit: Fix a couple of minor UI layout issues.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group