| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Coerce 'unknown' type parameters to the right type in the |
| Date: | 2010-08-18 15:03:34 |
| Message-ID: | 4C6BF646.1030200@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 18/08/10 16:57, Tom Lane wrote:
> heikki(at)postgresql(dot)org (Heikki Linnakangas) writes:
>> Log Message:
>> -----------
>> Coerce 'unknown' type parameters to the right type in the fixed-params
>> parse_analyze() function. That case occurs e.g with PL/pgSQL
>> EXECUTE ... USING 'stringconstant'.
>
>> The coercion with a CoerceViaIO node. The result is similar to the coercion
>> via input function performed for unknown constants in coerce_type(),
>> except that this happens at runtime.
>
> Unfortunately, this entirely fails to enforce the rule that an unknown
> Param be coerced the same way everywhere. You'd need a cleanup pass as
> well, cf check_variable_parameters().
Yeah, you're right. I'll find a way to do the cleanup pass in fixed
params case too.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2010-08-18 15:21:54 | pgsql: Add missing handling of PlannedStmt.transientPlan in |
| Previous Message | Tom Lane | 2010-08-18 13:57:19 | Re: pgsql: Coerce 'unknown' type parameters to the right type in the |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Fetter | 2010-08-18 15:05:50 | Re: proposal: tuplestore, tuplesort aggregate functions |
| Previous Message | Tom Lane | 2010-08-18 15:03:23 | Re: git: uh-oh |