Re: GSoC - Patch (Schema Difference Sync+ Visualization)

Le 16/08/2010 23:06, adeel khan a écrit :
> Hi,
>
>> The real issue is here, with the gcc compiler. Well, it's more your code
>> than gcc. There are loads and loads of errors and warnings. I already
>> fixed a few ones :
>>
>> * for the xpm files, "static char*" should be "static const char*"
>> * #endif should not have a semicolon at the end
>> * #include"" doesn't work, you need a space between the #include
>> keyword and the file path
>> * there's no pgadmin3.h, it should be replaced with pgAdmin3.h (notice
>> the upper A)
>> * svFkDiff.h is not the same thing than svFKDiff.h (notice the upper K)
>>
>> I don't need to continue, I think you got my point. Even with all these
>> fixes, I still get tons of warnings and errors. Seems there are a lot of
>> work still to do.
>>
>
> thanks , hm..it seems gcc is too much strict about names or about access
> modifiers. Well i have tested it only for windows, using VC 2008 (ver 9)
> You are compiling it on windows using gcc?
>

No, it isn't "too much" strict. It's just more strict, more precise than
VC++.

I'm compiling on Linux. I'm not sure I would get the same warning with
gcc on Windows (for example, the insensitive case name issue shouldn't
apply).

Anyway, next time, make sure you try with gcc. It helps find stuff that
VC++ doesn't care about.

I'm gonna wait that we find a way to work together before working again
on your patch. The same applies to Luis. I don't want to lose time
and/or work. We first need to agree on how we work concurrently on those
projects.

--
Guillaume
http://www.postgresql.fr
http://dalibo.com