Skip site navigation (1) Skip section navigation (2)

Re: Reviewfest 2010-06 Plans and Call for Reviewers

From: "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
To: "Robert Haas" <robertmhaas(at)gmail(dot)com>
Cc: <pgsql-hackers(at)postgresql(dot)org>,<pgsql-rrreviewers(at)postgresql(dot)org>
Subject: Re: Reviewfest 2010-06 Plans and Call for Reviewers
Date: 2010-07-08 16:44:37
Message-ID: 4C35BA250200002500033252@gw.wicourts.gov (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-rrreviewers
Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
 
> Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov> wrote:
>>> or had major design issues
>>
>> That's a much harder problem.  The set of people who can review
>> for that is rather smaller than the set who can see if a patch
>> applies without error.
> 
> Well, true.  But reporting whether the patch applies without error
> is about the most minimal review possible
 
I didn't mean to imply that only the two extremes of review ("does
the patch apply?" and "does this patch have a major overall design
flaw?") were the only things to try to address now; I was just
responding to your observation that these comprised a lot of the
activity of the first CommitFest last year, and that the latter is
harder to address without a review by a senior developer.  I suspect
that one person could check for bitrot in all pending patches with a
one or two FTE day's effort, and if that's done within the next few
days, it might allow time for fixes before the start of the CF free
up more of the first week of the CF to more substantive review.
 
Nice comments later in the email, though; I hope you won't mind if
you find excerpts popping up in the code review Wiki pages.  ;-)
 
-Kevin

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2010-07-08 16:46:42
Subject: Re: [HACKERS] pgsql: Add support for TCP keepalives on Windows, both for backend and
Previous:From: Magnus HaganderDate: 2010-07-08 16:42:18
Subject: Re: [HACKERS] pgsql: Add support for TCP keepalives on Windows, both for backend and

pgsql-rrreviewers by date

Next:From: Robert HaasDate: 2010-07-08 17:03:00
Subject: Re: Reviewfest 2010-06 Plans and Call for Reviewers
Previous:From: Robert HaasDate: 2010-07-08 16:29:47
Subject: Re: Reviewfest 2010-06 Plans and Call for Reviewers

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group