Skip site navigation (1) Skip section navigation (2)

Re: Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes.

From: Greg Smith <greg(at)2ndquadrant(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, Josh Berkus <josh(at)agliodbs(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes.
Date: 2010-07-06 21:49:15
Message-ID: 4C33A4DB.3060503@2ndquadrant.com (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Robert Haas wrote:
> Bruce felt it wasn't worth putting that amount of work into backbranch docs that nobody's likely to read
> anyway, but I suppose that view could be overruled if there's a strong consensus.
>   

I was never arguing in favor of touching anything in the back branches; 
if you recall I didn't even voice an opinion here until I got concerned 
about too many changes happening in them.  I think a proper fix in 9.0 
combined with a release notes comment noting the old/new behavior, so 
it's clear what was broken in the old versions, would be quite enough here.

Something like this maybe:

Change log_temp_files to be set in and output its value in kilobytes.  
Older versions had the parameter labeled and documented as being in KB, 
while it was actually set and outputting to the logs in bytes.

Thanks for following this through, I think it's a useful small bit to 
get sorted out fully.

-- 
Greg Smith  2ndQuadrant US  Baltimore, MD
PostgreSQL Training, Services and Support
greg(at)2ndQuadrant(dot)com   www.2ndQuadrant.us


In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2010-07-06 21:49:37
Subject: Re: [COMMITTERS] pgsql: Add note that using PL/Python 2 and 3 in the same session will
Previous:From: Tom LaneDate: 2010-07-06 21:41:11
Subject: Does mbutils.c really need to use L'\0' ?

pgsql-committers by date

Next:From: Tom LaneDate: 2010-07-06 21:49:37
Subject: Re: [COMMITTERS] pgsql: Add note that using PL/Python 2 and 3 in the same session will
Previous:From: Peter EisentrautDate: 2010-07-06 21:37:31
Subject: pgsql: Add note that using PL/Python 2 and 3 in the same session will

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group