Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Mention why one C file fails pgindent.

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Bruce Momjian <momjian(at)postgresql(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Mention why one C file fails pgindent.
Date: 2010-07-06 21:34:03
Message-ID: 4C33A14B.4060103@dunslane.net (view raw or flat)
Thread:
Lists: pgsql-committers

Bruce Momjian wrote:
> Log Message:
> -----------
> Mention why one C file fails pgindent.
>
> Modified Files:
> --------------
>     pgsql/src/tools/pgindent:
>         README (r1.41 -> r1.42)
>         (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/tools/pgindent/README?r1=1.41&r2=1.42)
>
>   

Why not add the file that breaks to 
src/tools/pgindent/exclude_file_patterns? (And also maybe the file Tom 
just fixed).

And ISTM we should have a list of typdefs for pgindent to ignore anyway. 
Currently, the buildfarm ignores:

    'date','interval','timestamp','ANY'

We should probably add 'DECIMAL' to that list.

But really, this list should probably be part of pgindent, not of the 
typedef finding code.

cheers

andrew

In response to

Responses

pgsql-committers by date

Next:From: Peter EisentrautDate: 2010-07-06 21:37:31
Subject: pgsql: Add note that using PL/Python 2 and 3 in the same session will
Previous:From: Robert HaasDate: 2010-07-06 21:14:25
Subject: pgsql: Support setting the keepalive idle time on MacOS X.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group