Robert Haas wrote:
> It doesn't seem very palatable to have multiple handwritten integer
> parsers floating around the code base either. Maybe we should try to
> standardize something and ship it in src/port, or somesuch
I was considering at one point making two trips through strtol, each
allowed to gobble 10 characters, then combining the two--just to cut
down a little bit on the roll your own parser aspects here. I hadn't
really considered how the main server does this job though. If there's
something reasonable to expose by refactoring some code that's already
there, I could take a stab at that. I'm not exactly sure where the
integer parsing code in the server that would be appropriate is to break
out is at though.
--
Greg Smith 2ndQuadrant US Baltimore, MD
PostgreSQL Training, Services and Support
greg(at)2ndQuadrant(dot)com www.2ndQuadrant.us
In response to
Responses
pgsql-hackers by date
| Next: | From: Robert Haas | Date: 2010-07-06 15:03:24 |
| Subject: Re: 64-bit pgbench V2 |
| Previous: | From: Robert Haas | Date: 2010-07-06 14:52:48 |
| Subject: Re: Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes. |