Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Allow copydir() to be interrupted.

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org, Magnus Hagander <magnus(at)hagander(dot)net>
Subject: Re: [COMMITTERS] pgsql: Allow copydir() to be interrupted.
Date: 2010-07-02 23:30:17
Message-ID: 4C2E7689.8070601@dunslane.net (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers

Robert Haas wrote:
>>> I suspect that moving copydir.c into the backend will fix this, but I
>>> don't have an appropriate build environment to test.  Can someone
>>> please test the attached patch?
>>>       
>> Andrew confirms that this works on mingw, so I'm going to go ahead and
>> check it in and see what happens.
>>     
>
> hamerkop [Windows Server 2008 R2 (64bit) Visual C++ 2005 AMD64] is not
> happy with this.
>
> http://pgbuildfarm.org/cgi-bin/show_log.pl?nm=hamerkop&dt=2010-07-02%2018:45:44
>
> I don't really understand most of the log messages, but the problem
> seems to be here (some garbage removed for clarity):
>
> LINK : fatal error LNK1104: '.\Release\postgres\src_port_copydir.obj'
> LIB : fatal error LNK1181: '.\Release\libpgport\copydir.obj'
>
> What doesn't make sense about that is that that file should not have
> existed in the snapshot hamerkop ran against.
>
>   

MSVC was looking for it and not finding it. I have committed a fix that 
I hope will fix the MSVC builds, by removing it from the list of files 
in libpgport.

cheers

andrew

In response to

Responses

pgsql-hackers by date

Next:From: Markus WannerDate: 2010-07-02 23:44:46
Subject: dynamically allocating chunks from shared memory
Previous:From: Bruce MomjianDate: 2010-07-02 23:20:41
Subject: Re: _bt_parent_deletion_safe() isn't safe

pgsql-committers by date

Next:From: Robert HaasDate: 2010-07-03 00:32:39
Subject: Re: [COMMITTERS] pgsql: Allow copydir() to be interrupted.
Previous:From: Andrew DunstanDate: 2010-07-02 23:25:27
Subject: pgsql: Unbreak MSVC builds by removing copydir.c from list of libpgport

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group