Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say
bytes not kilobytes.
From:
Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To:
Simon Riggs <sriggs(at)postgresql(dot)org>
Cc:
PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org>
Subject:
Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say
bytes not kilobytes.
Date:
2010-06-25 14:25:50
Message-ID:
4C24BC6E.1030908@enterprisedb.com (view raw or flat )
Thread:
2010-06-25 13:11:25 from sriggs(at)postgresql(dot)org (Simon Riggs)
2010-06-25 14:25:50 from Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
2010-06-25 15:11:03 from Simon Riggs <simon(at)2ndQuadrant(dot)com>
2010-06-25 17:56:44 from Josh Berkus <josh(at)agliodbs(dot)com>
2010-06-27 11:48:46 from Simon Riggs <simon(at)2ndQuadrant(dot)com>
2010-07-06 14:21:06 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-07-06 14:42:16 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-07-06 14:52:48 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-07-06 15:03:45 from Bruce Momjian <bruce(at)momjian(dot)us>
2010-07-06 15:05:06 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-07-06 15:10:18 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-07-06 15:17:02 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-07-06 15:25:21 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-07-06 15:29:38 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-07-06 18:38:48 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-07-06 19:40:31 from Greg Smith <greg(at)2ndquadrant(dot)com>
2010-07-06 20:01:30 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-07-06 21:49:15 from Greg Smith <greg(at)2ndquadrant(dot)com>
2010-07-06 23:09:21 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-07-06 15:06:05 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-07-07 22:48:23 from Josh Berkus <josh(at)agliodbs(dot)com>
2010-07-08 00:32:12 from Cédric Villemain <cedric(dot)villemain(dot)debian(at)gmail(dot)com>
2010-07-06 14:51:56 from Greg Smith <greg(at)2ndquadrant(dot)com>
Lists:
pgsql-committers pgsql-hackers
On 25/06/10 16:11, Simon Riggs wrote:
> Log Message:
> -----------
> Fix log_temp_files docs and comments to say bytes not kilobytes.
> stat(2) field st_size returns bytes not kilobytes.
> Bug found during recent performance tuning for PostgreSQL user.
>
> Modified Files:
> --------------
> pgsql/doc/src/sgml:
> config.sgml (r1.282 -> r1.283)
> (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/config.sgml?r1=1.282&r2=1.283 )
> pgsql/src/backend/utils/misc:
> guc.c (r1.556 -> r1.557)
> (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/misc/guc.c?r1=1.556&r2=1.557 )
Hmm, GUC_UNIT_KB doesn't seem appropriate anymore. I'd suggest changing
the code to match the documentation instead.
Shouldn't this be backpatched, or was this a new bug in 9.0?
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
In response to
Responses
pgsql-hackers by date
Next :From: Simon RiggsDate: 2010-06-25 15:11:03Subject : Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to
say bytes not kilobytes.Previous :From : Tom LaneDate : 2010-06-25 14:17:32Subject : Re: testing plpython3u on 9.0beta2
pgsql-committers by date
Next :From: Simon RiggsDate: 2010-06-25 15:11:03Subject : Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to
say bytes not kilobytes.Previous :From : Kevin GrittnerDate : 2010-06-25 13:34:25Subject : Re: pgsql: Add TCP keepalive support to libpq.
