Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes.

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Simon Riggs <sriggs(at)postgresql(dot)org>
Cc: PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org>
Subject: Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes.
Date: 2010-06-25 14:25:50
Message-ID: 4C24BC6E.1030908@enterprisedb.com (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On 25/06/10 16:11, Simon Riggs wrote:
> Log Message:
> -----------
> Fix log_temp_files docs and comments to say bytes not kilobytes.
> stat(2) field st_size returns bytes not kilobytes.
> Bug found during recent performance tuning for PostgreSQL user.
>
> Modified Files:
> --------------
>      pgsql/doc/src/sgml:
>          config.sgml (r1.282 ->  r1.283)
>          (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/config.sgml?r1=1.282&r2=1.283)
>      pgsql/src/backend/utils/misc:
>          guc.c (r1.556 ->  r1.557)
>          (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/misc/guc.c?r1=1.556&r2=1.557)

Hmm, GUC_UNIT_KB doesn't seem appropriate anymore. I'd suggest changing 
the code to match the documentation instead.

Shouldn't this be backpatched, or was this a new bug in 9.0?

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com

In response to

Responses

pgsql-hackers by date

Next:From: Simon RiggsDate: 2010-06-25 15:11:03
Subject: Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes.
Previous:From: Tom LaneDate: 2010-06-25 14:17:32
Subject: Re: testing plpython3u on 9.0beta2

pgsql-committers by date

Next:From: Simon RiggsDate: 2010-06-25 15:11:03
Subject: Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes.
Previous:From: Kevin GrittnerDate: 2010-06-25 13:34:25
Subject: Re: pgsql: Add TCP keepalive support to libpq.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group