Re: pgsql: Add TCP keepalive support to libpq.

From: "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
To: "Robert Haas" <robertmhaas(at)gmail(dot)com>, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Simon Riggs" <simon(at)2ndquadrant(dot)com>, "Florian Pflug" <fgp(at)phlo(dot)org>, <pgsql-hackers(at)postgresql(dot)org>, "Robert Haas" <rhaas(at)postgresql(dot)org>
Subject: Re: pgsql: Add TCP keepalive support to libpq.
Date: 2010-06-25 13:34:25
Message-ID: 4C246A110200002500032AF5@gw.wicourts.gov
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> wrote:

> Here's an attempt at rewording the sections so that the
> information is included in each parameter's description without
> taking up a whole sentence.
>
> Thoughts?

It makes the point without beating one over the head with it. I
particularly like the way this patch moves the main point of the
parameter to the front, with all the conditions under which it might
be ignored pushed farther back. It reads much better that way, at
least for me.

-Kevin

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2010-06-25 14:25:50 Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes.
Previous Message Robert Haas 2010-06-25 13:15:18 Re: [COMMITTERS] pgsql: Add TCP keepalive support to libpq.

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2010-06-25 14:17:32 Re: testing plpython3u on 9.0beta2
Previous Message Robert Haas 2010-06-25 13:15:18 Re: [COMMITTERS] pgsql: Add TCP keepalive support to libpq.