Skip site navigation (1) Skip section navigation (2)

Re: dividing money by money

From: "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
To: <andy(at)balholm(dot)com>
Cc: <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: dividing money by money
Date: 2010-05-30 13:53:53
Message-ID: 4C0227A10200002500031C17@gw.wicourts.gov (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-www
Andy Balholm  wrote:
On May 26, 2010, at 11:18 AM, Kevin Grittner wrote:

>> Do you want to package this up as a patch for 9.1? If not, is it
>> OK if I do?
 
> I'm not quite sure how to go about changing it from an add-on
> function to a built-in one. So if you want to do that, go ahead. If
> you'd rather I did, just tell me how it's done.
 
You would basically move the functions and their prototypes to cash.c
and cash.h, and then (instead of CREATE FUNCTION, etc.) add
corresponding entries to pg_proc.h and pg_operator.h.  (If I'm
missing something, someone please jump in.) Of course there's the
issue of adding the new operators to the documentation, too.
 
You would then generate a diff in context format and post to the
-hackers list with that file as an attachment.  Don't forget to add
it to the "CommitFest" page:
 
https://commitfest.postgresql.org/action/commitfest_view/open
 
If you're going to do this, be sure to breeze through the developer's
FAQ:
 
http://wiki.postgresql.org/wiki/Developer_FAQ
 
Of course, if that's all too daunting, I can do it, but it seems to
me that you've already done the hard part (in creating working
functions), so I figured it might be satisfying for you to see it
through to the end.
 
-Kevin

Responses

pgsql-www by date

Next:From: Andy BalholmDate: 2010-05-30 22:54:57
Subject: Re: dividing money by money
Previous:From: Stefan KaltenbrunnerDate: 2010-05-28 20:16:45
Subject: Re: update Summer of Code links/info

pgsql-hackers by date

Next:From: Tom LaneDate: 2010-05-30 14:01:46
Subject: Re: small exclusion constraints patch
Previous:From: Andrew DunstanDate: 2010-05-30 13:11:40
Subject: Re: Winflex

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group