Re: Re: [COMMITTERS] pgsql: Make CheckRequiredParameterValues() depend upon correct

Tom Lane wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
>> Hmm, AFAICS the problem with controldata is that it uses postgres_fe.h
>> instead of postgres.h. It's a bit of a stretch to use the latter, but
>> maybe that's a better solution? After all, it *is* poking into the
>> backend internals.
>
> I seem to recall that Solaris had problems with that due to dtrace
> support or something? However, we are doing it in pg_resetxlog,
> so I suppose it's ok for pg_controldata as well.

Ok, did that. Here's an updated patch:

* made incorrect combinations of wal_mode and
archive_mode/max_wal_senders throw an ERROR instead of WARNING

* renamed wal_mode to wal_level

* reworded the documentation changes a bit

This doesn't contain any changes to pg_start_backup() yet, that's a
separate issue and still under discussion.

At commit, should I bump catversion, or PG_CONTROL_VERSION, or both? The
patch replaces the unlogged-operation WAL record with a record
containing current parameter values, and it changes pg_control. I'm
guessing both.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com