Skip site navigation (1) Skip section navigation (2)

Issues with my patch on the groups of servers

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: pgadmin-hackers(at)postgresql(dot)org
Subject: Issues with my patch on the groups of servers
Date: 2010-04-26 09:51:15
Message-ID: 4BD56213.5060504@lelarge.info (view raw or flat)
Thread:
Lists: pgadmin-hackers
Hi,

While working on the connection combobox for frmQuery, I found some
rather amusing (or not) bugs in my patch for groups of servers. It seems
there are quite a few use of the browser that don't like groups. pgAdmin
doesn't crash, but is not more able to discover servers. Take
dlgSelectConnection for example. It doesn't crash pgAdmin, but a user
can't select a new connection because the dialog doesn't find servers
and disables server and database comboboxes. And I think other
components will be hit by this.

There is surely simple fixes for them. Problem is: I'm not sure I'll
have the time to work on those. It could be I will, but I'm simply not sure.

So, I'm a bit hesitant on what to do. I could revert my previous patch,
and push it in once it's clearly good... but it could be good enought,
one day after the release of beta 1. I could also try to fix the issues
(I don't think they are that many), but what should we do if I can't
have a good enough behaviour when beta 1 will be wrapped up?

I'm actually working on these bugs. So I kind of prefer #2. Any strong
opinion on this?


-- 
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

Responses

pgadmin-hackers by date

Next:From: Dave PageDate: 2010-04-26 10:01:01
Subject: Re: Issues with my patch on the groups of servers
Previous:From: Guillaume LelargeDate: 2010-04-25 21:18:31
Subject: Re: Comments on some tickets

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group