Skip site navigation (1) Skip section navigation (2)

Re: Ticket 3: groups of servers

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: Ticket 3: groups of servers
Date: 2010-04-23 22:25:27
Message-ID: 4BD21E57.5040709@lelarge.info (view raw or flat)
Thread:
Lists: pgadmin-hackers
Le 23/04/2010 15:00, Dave Page a écrit :
> On Thu, Apr 22, 2010 at 8:26 PM, Guillaume Lelarge
> <guillaume(at)lelarge(dot)info> wrote:
>> Well, we didn't do it for the actual Servers node. I don't think we
>> should do it for this one.
> 
> Right - that's why I wasn't sure. And now that groups are root nodes,
> it seems even less important.
> 
>> Finally, I had time to work on this. I changed my patch so that it
>> follows what you expected to see. I was not really able to reproduce the
>> problem you explain above after my changes.
>>
>> Can you try this last one? Thanks.
> 
> Still seeing a crash on OSX, but mostly I think it's good now. Here's
> what happened:
> 
> - I cleared my prefs file so I just had 4 servers detected and added
> to the 'Servers' group at startup.
> 
> - I moved 3 of the servers to a new 'PostgreSQL' group.
> 
> - I moved 1 server to a new 'Advanced Server' group.
> 
> At this point I had three groups visible:
> 
> Servers (0)
> PostgreSQL (3)
>   - Server 1
>   - Server 2
>   - Server 3
> Advanced Server (1)
>   Server 4
> 
> Gripe 1: I think the Servers group should be hidden if it's empty. In
> previous versions it didn't really matter as the first thing you'd do
> is add a server. Now though, it might remain empty forever.
> 

Fixed. I still keep a "Servers" item in the combobox, even if there is
no "Servers" group. No sure this is really smart. Should I get rid of it?

> Gripe 2: I think the groups should be shown in alphabetical order.
> Should be a one-line change :-)
> 

Fixed.

> - I then right-clicked Server 4 and selected Properties
> 
> Gripe 3: pgAdmin crashes reliably at this point:
> 

Fixed.

Thanks for your comments. See patch attached.


-- 
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

Attachment: ticket3_v4.patch
Description: text/x-patch (29.5 KB)

In response to

Responses

pgadmin-hackers by date

Next:From: Dave PageDate: 2010-04-23 22:32:49
Subject: Re: Ticket 3: groups of servers
Previous:From: Ashesh VashiDate: 2010-04-23 21:44:23
Subject: Re: PATCH(WIP): Printing Support And Save GQB/Explain as an image

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group