Skip site navigation (1) Skip section navigation (2)

Re: Re: [COMMITTERS] pgsql: Make standby server continuously retry restoring the next WAL

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, Aidan Van Dyk <aidan(at)highrise(dot)ca>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [COMMITTERS] pgsql: Make standby server continuously retry restoring the next WAL
Date: 2010-03-30 16:28:28
Message-ID: 4BB226AC.4020205@enterprisedb.com (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-docspgsql-hackers
Fujii Masao wrote:
>> * Small code changes to handling of failedSources, inspired by your
>> comment. No change in functionality.
>>
>> This is also available in my git repository at
>> git://git.postgresql.org/git/users/heikki/postgres.git, branch "xlogchanges"
> 
> I looked the patch and was not able to find any big problems until now.
> The attached small patch fixes the typo.

Thanks. Committed with that typo-fix, and I also added a comment
explaining how failedSources and retrying XLogPageRead() works.

I'm now happy with the standby mode logic. It was a bigger struggle than
I anticipated back in January/February, I hope others now find it
intuitive as well. I'm going to work on the documentation of this, along
the lines of the draft I posted last week.

-- 
  Heikki Linnakangas
  EnterpriseDB   http://www.enterprisedb.com

In response to

Responses

pgsql-docs by date

Next:From: Fujii MasaoDate: 2010-03-31 02:01:40
Subject: Re: Re: [COMMITTERS] pgsql: Make standby server continuously retry restoring the next WAL
Previous:From: Fujii MasaoDate: 2010-03-30 08:52:19
Subject: Streaming replication document improvements

pgsql-hackers by date

Next:From: Heikki LinnakangasDate: 2010-03-30 16:42:41
Subject: Re: OK for ABI break of PlannerInfo in 8.4?
Previous:From: Tom LaneDate: 2010-03-30 15:31:25
Subject: OK for ABI break of PlannerInfo in 8.4?

pgsql-committers by date

Next:From: Tom LaneDate: 2010-03-30 21:58:11
Subject: pgsql: Fix "constraint_exclusion = partition" logic so that it will also
Previous:From: Heikki LinnakangasDate: 2010-03-30 16:23:57
Subject: pgsql: Change the retry-loop in standby mode to also try restoring files

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group