Skip site navigation (1) Skip section navigation (2)

Re: Rework of the frmOptions window

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Rework of the frmOptions window
Date: 2010-03-27 15:05:52
Message-ID: 4BAE1ED0.6090800@lelarge.info (view raw or flat)
Thread:
Lists: pgadmin-hackers
Le 27/03/2010 15:05, Dave Page a écrit :
> On Wed, Mar 24, 2010 at 7:05 PM, Guillaume Lelarge
> <guillaume(at)lelarge(dot)info> wrote:
>> Hi,
>>
>> Since our frmOptions is so badly displayed, I've put some work on it:
>>
>>  * Sizers everywhere!
>>  * Replace widgets with a wxDirPickerCtrl.
>>  * Replace widgets with a wxFilePickerCtrl.
>>  * Replace widgets with a wxFontPickerCtrl.
>>  * Minimize the dialog size.
>>
>> Dave, if you have Snow Leopard, can you check this patch? if
>> wxFontDialog is still broken on Mac OS X, I'll need to revert this git
>> commit. Thanks.
> 
> Sure. There's an issue on the first tab, where the text at the bottom
> is truncated.

Was already fixed in my local git branch. But thanks :)

> Other than that, it looks OK technically speaking, but
> the controls (and form) are getting so wide they're starting to look
> very 'in your face'. FWIW, Magnus was of a similar opinion when I
> showed him the dialogue.
> 

Yeah, I agree too. Mainly with the colour buttons.

One way we can fix this is lowering the width of the dialog. If we do
that, we need to lessen the number of tabs. One way would be to put all
colours options in the same tab. IIRC, you already mentionned it.

Another way would be to have four columns, instead of two right now. Not
sure it will be better displayed this way.

>> Apart from this, seems good enough for me.
> 
> I think it's good enough to use. It certainly does need a rethink in
> the longer term though.
> 

We can still think of it now. We still have time.

I'll try the first way (lower the width of the dialog).


-- 
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

In response to

Responses

pgadmin-hackers by date

Next:From: svnDate: 2010-03-27 15:11:43
Subject: SVN Commit by dpage: r8245 - in trunk/pgadmin3: . pgadmin pgadmin/dlg pgadmin/frm pgadmin/include/dlg pgadmin/include/schema pgadmin/schema pgadmin/ui pgadmin/utils
Previous:From: Dave PageDate: 2010-03-27 14:05:37
Subject: Re: Rework of the frmOptions window

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group