| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, Aidan Van Dyk <aidan(at)highrise(dot)ca>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Make standby server continuously retry restoring the next WAL |
| Date: | 2010-03-25 12:48:27 |
| Message-ID: | 4BAB5B9B.80203@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-docs pgsql-hackers |
Fujii Masao wrote:
>> sources &= ~failedSources;
>> failedSources |= readSource;
>
> The above lines in XLogPageRead() seem not to be required in normal
> recovery case (i.e., standby_mode = off). So how about the attached
> patch?
>
> *** 9050,9056 **** next_record_is_invalid:
> --- 9047,9056 ----
> readSource = 0;
>
> if (StandbyMode)
> + {
> + failedSources |= readSource;
> goto retry;
> + }
> else
> return false;
That doesn't work because readSource is cleared above. But yeah,
failedSources is not needed in archive recovery, so that line can be
removed.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2010-03-25 12:55:42 | Re: Re: [COMMITTERS] pgsql: Make standby server continuously retry restoring the next WAL |
| Previous Message | User Kasahara | 2010-03-25 11:13:16 | pgstatsinfo - pg_statsinfo: Fix small typo in collector_sql.h |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2010-03-25 12:55:42 | Re: Re: [COMMITTERS] pgsql: Make standby server continuously retry restoring the next WAL |
| Previous Message | Heikki Linnakangas | 2010-03-25 10:47:07 | Re: Re: [COMMITTERS] pgsql: Make standby server continuously retry restoring the next WAL |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2010-03-25 12:55:42 | Re: Re: [COMMITTERS] pgsql: Make standby server continuously retry restoring the next WAL |
| Previous Message | Heikki Linnakangas | 2010-03-25 10:47:07 | Re: Re: [COMMITTERS] pgsql: Make standby server continuously retry restoring the next WAL |