Re: Confusing link in streaming replication section

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Thom Brown <thombrown(at)gmail(dot)com>, pgsql-docs(at)postgresql(dot)org
Subject: Re: Confusing link in streaming replication section
Date: 2010-02-25 10:41:35
Message-ID: 4B8653DF.3000009@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs

Fujii Masao wrote:
> On Thu, Feb 25, 2010 at 6:15 PM, Heikki Linnakangas
> <heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
>> Yeah, it's not very clear as it is.
>>
>> How about this:
>>
>> --- a/doc/src/sgml/recovery-config.sgml
>> +++ b/doc/src/sgml/recovery-config.sgml
>> @@ -193,7 +193,8 @@ restore_command = 'copy "C:\\server\\archivedir\\%f"
>> "%p"'
>> <listitem>
>> <para>
>> Specifies a connection string to be used for the standby server
>> - to connect with the primary. This string is in the same format as
>> + to connect with the primary. This string is in the format
>> + accepted by the libpq <function>PQconnectdb</function> function,
>> described in <xref linkend="libpq-connect">. If any option is
>> unspecified in this string, then the corresponding environment
>> variable (see <xref linkend="libpq-envars">) is checked. If the
>
> The following description in the document about PQconnectdb() doesn't fit
> primary_conninfo because of restriction of readRecoveryCommandFile().
>
> ---------------
> To write an empty value, or a value containing spaces,
> surround it with single quotes, e.g., keyword = 'a value'. Single quotes
> and backslashes within the value must be escaped with a backslash,
> i.e., \' and \\.
> ---------------

Hmm, so how does one escape quotes in recovery.conf? That would be valid
information, if readRecoveryCommandFile() didn't choke on quotes.

At some point we'll have to make the recovery.conf parsing smarter, if
only for consistency with postgresql.conf, or merge them completely...

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

In response to

Responses

Browse pgsql-docs by date

  From Date Subject
Next Message Fujii Masao 2010-02-25 11:04:03 Re: Confusing link in streaming replication section
Previous Message Magnus Hagander 2010-02-25 10:02:40 Re: Typo in updated plperl docs