| From: | Kurt Harriman <harriman(at)acm(dot)org> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Patch: Remove gcc dependency in definition of inline functions |
| Date: | 2010-02-10 09:00:52 |
| Message-ID: | 4B7275C4.8030304@acm.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 1/18/2010 11:48 PM, Peter Eisentraut wrote:
> On mån, 2010-01-18 at 16:34 -0800, Kurt Harriman wrote:
>> MSVC does warn about unused static inline functions. The warning
>> is prevented by using __forceinline instead of __inline.
>
> Hmm, but forceinline is not the same as inline. Are we confident that
> forcing inlining is not going to lead to disadvantages? Has this been
> measured?
>
> Is there not a setting to disable this particular warning. I read that
> MSVC has various ways to set that sort of thing.
On further investigation, plain __inline works alright, at least in
Visual Studio 2005. The warning for unused static inline functions
only comes up when compiling C++, not C. I've submitted a revised
patch, no longer using __forceinline.
Regards, ... kurt
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Leonardo F | 2010-02-10 09:11:40 | Re: I: About "Our CLUSTER implementation is pessimal" patch |
| Previous Message | Kurt Harriman | 2010-02-10 08:53:48 | Re: Patch: Remove gcc dependency in definition of inline functions |