Skip site navigation (1) Skip section navigation (2)

Re: Add on_plperl_init and on_plperlu_init to plperl UPDATE 3 [PATCH]

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tim Bunce <Tim(dot)Bunce(at)pobox(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Add on_plperl_init and on_plperlu_init to plperl UPDATE 3 [PATCH]
Date: 2010-02-08 01:25:33
Message-ID: 4B6F680D.9090800@dunslane.net (view raw or flat)
Thread:
Lists: pgsql-hackers
Tim Bunce wrote:
> This is the third update to the fourth of the patches to be split out
> from the former 'plperl feature patch 1'.
>
> Changes in this patch:
>
> - Added plperl.on_plperl_init and plperl.on_plperlu_init GUCs
>     Both are PGC_SUSET
>     SPI functions are not available when the code is run.
>     Errors are detected and reported as ereport(ERROR, ...)
>     Corresponding documentation and tests for both.
>
> - Renamed plperl.on_perl_init to plperl.on_init
>
> - Improved state management of select_perl_context()
>     An error during interpreter initialization will leave
>     the state (interp_state etc) unchanged.
>
> - The utf8fix code has been greatly simplified.
>
> - More code comments re PGC_SUSET and no access to SPI functions.
>
>   


The docs on this patch need some cleaning up and expanding:

    * The possible insecurity of %_SHARED needs expanding.
    * The docs still refer to plperl.on_untrusted_init
    * plperl.on_plperl_init and plperl.on_plperlu_init can be documented
      together rather than repeating the same stuff almost word for word.
    * extra examples for these two, and an explanation of why one might
      want to use each of the three on*init settings would be good.

I'll continue reviewing the patch, but these things at least need fixing.

cheers

andrew



In response to

Responses

pgsql-hackers by date

Next:From: Andrew McNamaraDate: 2010-02-08 01:25:43
Subject: Re: Confusion over Python drivers
Previous:From: Fujii MasaoDate: 2010-02-08 01:01:40
Subject: Re: Backup history file should be replicated in Streaming Replication?

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group