Skip site navigation (1) Skip section navigation (2)

Re: BUG #5304: psql using conninfo fails in connecting to the server

From: Joe Conway <mail(at)joeconway(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #5304: psql using conninfo fails in connecting to the server
Date: 2010-02-04 17:37:47
Message-ID: 4B6B05EB.2010802@joeconway.com (view raw or flat)
Thread:
Lists: pgsql-bugspgsql-hackers
On 02/04/2010 08:31 AM, Joe Conway wrote:
> On 02/04/2010 01:23 AM, Fujii Masao wrote:
>> On Thu, Feb 4, 2010 at 1:26 PM, Joe Conway <mail(at)joeconway(dot)com> wrote:
>>> OK, this one includes pg_dump(all)/pg_restore and common.c from
>>> bin/scripts (createdb, vacuumdb, etc). I still need to adjust the docs,
>>> but other than that any remaining complaints?
> 
>> * expand_dbname is defined as a "bool" value in PQconnectdbParams()
>>   and PQconnectStartParams(). But we should hide such a "bool" from
>>   an user-visible API, and use an "int" instead?
> 
> Yes, I suppose there is precedence for that.
> 
>> * conninfo_array_parse() calls PQconninfoFree(str_options) as soon
>>   as one "dbname" keyword is found. So if more than one "dbname"
>>   keywords are unexpectedly specified in PQconnectdbParams(), the
>>   str_options would be free()-ed doubly.
> 
> Great catch -- thank you!
> 
> Thanks for the review. I'll do a documentation update, make these
> changes, and commit later today if I don't hear any other objections.

Attached has both items fixed and documentation changes.

Joe

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2010-02-04 18:02:13
Subject: Re: Re: [COMMITTERS] pgsql: Assorted cleanups in preparation for using a map file to support
Previous:From: Robert HaasDate: 2010-02-04 17:34:33
Subject: Re: Largeobject Access Controls (r2460)

pgsql-bugs by date

Next:From: Mark KirkwoodDate: 2010-02-04 23:21:12
Subject: Re: BUG #5312: I NEED HELP
Previous:From: Joe ConwayDate: 2010-02-04 16:31:21
Subject: Re: BUG #5304: psql using conninfo fails in connecting to the server

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group