| From: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
|---|---|
| To: | Euler Taveira de Oliveira <euler(at)timbira(dot)com> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: Ticket 117: Explain Buffers |
| Date: | 2010-02-03 19:39:16 |
| Message-ID: | 4B69D0E4.2030104@lelarge.info |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Le 26/01/2010 10:18, Guillaume Lelarge a écrit :
> Le 26/01/2010 04:13, Euler Taveira de Oliveira a écrit :
>> Guillaume Lelarge escreveu:
>>> New patch attached.
>>>
>> Nice job. But there are just a few gripes about your patch: (i) it doesn't
>> disable the EXPLAIN button when the BUFFERS option is enabled, (ii) it doesn't
>> disable the EXPLAIN ANALYZE menu when the query is running, and (iii) there is
>> a bug when the BUFFERS option is enabled and you close and open the query tool
>> again (the EXPLAIN menu turns enabled instead of disabled).
>>
>> The attached patch (on the top of your patch) addresses all of these problems.
>>
>
> Thanks a lot for your help. I added your patch, here is the new complete
> patch.
>
> Seems good to me. Any more comments before I apply it?
>
Commited.
--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | pgAdmin Trac | 2010-02-03 19:40:29 | Re: [pgAdmin III] #117: Explain Buffers |
| Previous Message | svn | 2010-02-03 19:38:35 | SVN Commit by guillaume: r8172 - in trunk/pgadmin3: . pgadmin/ctl pgadmin/frm pgadmin/include/frm pgadmin/include/utils |