Skip site navigation (1) Skip section navigation (2)

Re: Re: [COMMITTERS] pgsql: Write a WAL record whenever we perform an operation without

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Tatsuo Ishii <ishii(at)postgresql(dot)org>
Cc: masao(dot)fujii(at)gmail(dot)com, simon(at)2ndquadrant(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [COMMITTERS] pgsql: Write a WAL record whenever we perform an operation without
Date: 2010-02-03 10:50:06
Message-ID: 4B6954DE.5010500@enterprisedb.com (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Tatsuo Ishii wrote:
>> Fujii Masao wrote:
>>> On Mon, Feb 1, 2010 at 7:40 PM, Heikki Linnakangas
>>> <heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
>>>> So you get those messages when the table is *not* a temporary table. I
>>>> can see now what Fujii was trying to say. His patch seems Ok, though
>>>> perhaps it would be better to move the responsibility of calling
>>>> XLogReportUnloggedStatement() to the callers of heap_sync(). When I put
>>>> it in heap_sync(), I didn't take into account that it's sometimes called
>>>> just to flush buffers from buffer cache, not to fsync() non-WAL-logged
>>>> operations.
>>> As you said, I moved the responsibility of calling XLogReportUnloggedStatement()
>>> to the callers of heap_sync(). Here is the patch.
>> Committed. The use_wal parameter to end_heap_rewrite() was not
>> necessary, that information is already in RewriteState, so I took that out.
> 
> Are we going to bump up frontend/backend protocol version 3.0 to 3.x
> or some such?

No, this doesn't affect the normal FE/BE protocol. The message header
was added to the streaming replication messages that are sent within
CopyData messages.

-- 
  Heikki Linnakangas
  EnterpriseDB   http://www.enterprisedb.com

In response to

pgsql-hackers by date

Next:From: Chris CampbellDate: 2010-02-03 11:24:30
Subject: Recent vendor SSL renegotiation patches break PostgreSQL
Previous:From: Marko TiikkajaDate: 2010-02-03 10:31:03
Subject: Re: Review of Writeable CTE Patch

pgsql-committers by date

Next:From: Michael MeskesDate: 2010-02-03 13:56:27
Subject: pgsql: Fixed some typos in ECPG regression test suite that resulted in
Previous:From: Tatsuo IshiiDate: 2010-02-03 10:19:19
Subject: Re: Re: [COMMITTERS] pgsql: Write a WAL record whenever we perform an operation without

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group