Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Write a WAL record whenever we perform an operation without

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Write a WAL record whenever we perform an operation without
Date: 2010-02-03 10:03:00
Message-ID: 4B6949D4.4010703@enterprisedb.com (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Fujii Masao wrote:
> On Mon, Feb 1, 2010 at 7:40 PM, Heikki Linnakangas
> <heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
>> So you get those messages when the table is *not* a temporary table. I
>> can see now what Fujii was trying to say. His patch seems Ok, though
>> perhaps it would be better to move the responsibility of calling
>> XLogReportUnloggedStatement() to the callers of heap_sync(). When I put
>> it in heap_sync(), I didn't take into account that it's sometimes called
>> just to flush buffers from buffer cache, not to fsync() non-WAL-logged
>> operations.
> 
> As you said, I moved the responsibility of calling XLogReportUnloggedStatement()
> to the callers of heap_sync(). Here is the patch.

Committed. The use_wal parameter to end_heap_rewrite() was not
necessary, that information is already in RewriteState, so I took that out.

-- 
  Heikki Linnakangas
  EnterpriseDB   http://www.enterprisedb.com

In response to

Responses

pgsql-hackers by date

Next:From: Simon RiggsDate: 2010-02-03 10:05:29
Subject: Re: pgsql: Assorted cleanups in preparation for using a map file to support
Previous:From: Boszormenyi ZoltanDate: 2010-02-03 09:59:57
Subject: Re: NaN/Inf fix for ECPG Re: out-of-scope cursor errors

pgsql-committers by date

Next:From: Simon RiggsDate: 2010-02-03 10:05:29
Subject: Re: pgsql: Assorted cleanups in preparation for using a map file to support
Previous:From: Heikki LinnakangasDate: 2010-02-03 10:01:30
Subject: pgsql: Move the responsibility of writing a "unlogged WAL operation"

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group