Skip site navigation (1) Skip section navigation (2)

Re: BUG #5304: psql using conninfo fails in connecting to the server

From: Joe Conway <mail(at)joeconway(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #5304: psql using conninfo fails in connecting to the server
Date: 2010-02-03 06:21:08
Message-ID: 4B6915D4.4030908@joeconway.com (view raw or flat)
Thread:
Lists: pgsql-bugspgsql-hackers
On 02/02/2010 10:08 PM, Tom Lane wrote:
> Joe Conway <mail(at)joeconway(dot)com> writes:
>> Are there any of the psql parameters that we do not want to allow to be
>> overridden by the conninfo string?
> 
> Actually, now that I think about it, psql shouldn't be setting
> application_name at all.  It should be setting
> fallback_application_name, and I think that should be after the dbname
> so that it's not overridable.  The way it's being done now destroys the
> usefulness of the PGAPPNAME environment variable.

Easily done. I'll fix psql/command.c and the documentation tomorrow and
post another patch for review before committing.

Should I also be looking to replace all (or most) other instances of
PQsetdbLogin()?

Thanks!

Joe

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2010-02-03 06:23:13
Subject: Re: BUG #5304: psql using conninfo fails in connecting to the server
Previous:From: Tom LaneDate: 2010-02-03 06:08:36
Subject: Re: BUG #5304: psql using conninfo fails in connecting to the server

pgsql-bugs by date

Next:From: Tom LaneDate: 2010-02-03 06:23:13
Subject: Re: BUG #5304: psql using conninfo fails in connecting to the server
Previous:From: Tom LaneDate: 2010-02-03 06:08:36
Subject: Re: BUG #5304: psql using conninfo fails in connecting to the server

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group