(2010/02/02 11:09), Tom Lane wrote:
> KaiGai Kohei<kaigai(at)ak(dot)jp(dot)nec(dot)com> writes:
>> The attached one also clean up ATPrepAddColumn() and ATExecAddColumn() code,
>> not only ATPrepAlterColumnType(), according to what I mentioned above.
> What exactly do you claim is wrong with the ADD COLUMN case?
ADD COLUMN case works correctly, but it takes unnecessary loops,
because the find_all_inheritors() didn't provide the value to be
set on the new pg_attribute.attinhcount.
I'm saying it can be rewritten in more graceful manner using the
new expected_parents argument.
OSS Platform Development Division, NEC
KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
In response to
pgsql-hackers by date
|Next:||From: Robert Haas||Date: 2010-02-02 02:31:01|
|Subject: Re: [BUG?] strange behavior in ALTER TABLE ... RENAME TO on inherited columns|
|Previous:||From: Tom Lane||Date: 2010-02-02 02:09:51|
|Subject: Re: [BUG?] strange behavior in ALTER TABLE ... RENAME TO on inherited columns |