Skip site navigation (1) Skip section navigation (2)

Re: BUG #5288: Restoring a 7.4.5 -Fc dump using -j 2 segfaults (patch included)

From: Jon Erdman <postgresql(at)thewickedtribe(dot)net>
To: Chris Travers <chris(at)metatrontech(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #5288: Restoring a 7.4.5 -Fc dump using -j 2 segfaults (patch included)
Date: 2010-01-19 18:43:49
Message-ID: 4B55FD65.4070802@thewickedtribe.net (view raw or flat)
Thread:
Lists: pgsql-bugs
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Chris Travers wrote:
> Just weighing in here.
> 
> On Tue, Jan 19, 2010 at 9:15 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> It doesn't seem worth it
>> to try to support parallel restore from nearly-obsolete versions, and
>> I suspect that we couldn't do it even if we tried --- the reason the
>> representation got changed is that the old way simply didn't work for
>> any significant use of the dependency info.  Just ignoring the
>> dependencies, as your patch effectively proposes, is going to lead to
>> restore failures or worse.
> 
> Just to clarify, the only part that would not be supported would be
> the parallel part, right?

Far as I can tell yes, since this fix_dependencies() function is only
called for parallel restores code path.

That would seem to indicate that in the case of partial archives these
missing deps wouldn't cause any worse failure than they otherwise would,
since they'd be just as missing if you did a normal restore vs. a
parallel one.
- --

Jon T Erdman (aka StuckMojo)
    PostgreSQL Zealot
-----BEGIN PGP SIGNATURE-----

iEYEARECAAYFAktV/WUACgkQRAk1+p0GhSE6JwCeJ9Yalsx6nkffrxxjjfw5Te4M
g+cAnjimrcof/ziEda0kSLI4/A8ln5Jj
=pibw
-----END PGP SIGNATURE-----

In response to

Responses

pgsql-bugs by date

Next:From: Tom LaneDate: 2010-01-19 18:44:11
Subject: Re: BUG #5288: Restoring a 7.4.5 -Fc dump using -j 2 segfaults (patch included)
Previous:From: Chris TraversDate: 2010-01-19 18:37:49
Subject: Re: BUG #5288: Restoring a 7.4.5 -Fc dump using -j 2 segfaults (patch included)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group