| From: | Joe Conway <mail(at)joeconway(dot)com> |
|---|---|
| To: | Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Fix for memory leak in dblink |
| Date: | 2010-01-12 17:40:00 |
| Message-ID: | 4B4CB3F0.1000605@joeconway.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 01/11/2010 07:43 PM, Takahiro Itagaki wrote:
> There is a memory leak in dblink when we cancel a query during
> returning tuples. It could leak a PGresult because memory used
> by it is not palloc'ed one. I wrote a patch[1] before, but I've
> badly used global variables to track the resource.
>
> The attached is a cleaned up patch rewritten to use a tuplestore
> (SFRM_Materialize mode) to return tuples suggested at [2]. Since
> we don't return from the dblink function in tuplestore mode, we
> can surely release the PGresult with a PG_CATCH block even on error.
Thanks -- I'll review this weekend.
Joe
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2010-01-12 17:48:50 | Re: NOT NULL violation and error-message |
| Previous Message | Joshua D. Drake | 2010-01-12 17:38:13 | Re: mailing list archiver chewing patches |