Re: pgsql: Applied Zoltan's patch to remove hardware
dependant offset
| From: |
Andrew Dunstan <andrew(at)dunslane(dot)net> |
| To: |
Michael Meskes <meskes(at)postgresql(dot)org> |
| Cc: |
pgsql-committers(at)postgresql(dot)org, Zoltan Boszormenyi <zb(at)cybertec(dot)at> |
| Subject: |
Re: pgsql: Applied Zoltan's patch to remove hardware
dependant offset |
| Date: |
2010-01-06 14:21:49 |
| Message-ID: |
4B449C7D.9040601@dunslane.net (view raw or flat) |
| Thread: |
|
| Lists: |
pgsql-committers |
This patch still leaves in some uses of __FUNCTION__ which is breaking
non-gcc compilers: see for example
<http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=gypsy_moth&dt=2010-01-06%2013:50:01>
elog.h defines PG_FUNCNAME_MACRO which you should use instead.
cheers
andrew
Michael Meskes wrote:
> Log Message:
> -----------
> Applied Zoltan's patch to remove hardware dependant offset logging and
> superfluous include files.
>
> Modified Files:
> --------------
> pgsql/src/interfaces/ecpg/ecpglib:
> sqlda.c (r1.1 -> r1.2)
> (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/ecpg/ecpglib/sqlda.c?r1=1.1&r2=1.2)
> pgsql/src/interfaces/ecpg/test/expected:
> compat_informix-sqlda.stderr (r1.1 -> r1.2)
> (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/ecpg/test/expected/compat_informix-sqlda.stderr?r1=1.1&r2=1.2)
> sql-sqlda.stderr (r1.1 -> r1.2)
> (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/ecpg/test/expected/sql-sqlda.stderr?r1=1.1&r2=1.2)
>
>
In response to
pgsql-committers by date
| Next: | From: Andrew Dunstan | Date: 2010-01-06 14:34:53 |
| Subject: Re: pgsql: Applied Zoltan's patch to remove hardware
dependant offset |
| Previous: | From: Michael Meskes | Date: 2010-01-06 11:59:52 |
| Subject: pgsql: Removed test case using nan as float value because printf's |