Skip site navigation (1) Skip section navigation (2)

Re: exec_execute_message crash

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tatsuo Ishii <ishii(at)postgresql(dot)org>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: exec_execute_message crash
Date: 2009-12-30 12:59:25
Message-ID: 4B3B4EAD.5090001@dunslane.net (view raw or flat)
Thread:
Lists: pgsql-hackers

Tatsuo Ishii wrote:
> ! 	if (!PortalIsValid(portal) || (PortalIsValid(portal) && portal->cleanup == NULL))
>  
>   


Surely the second call to PortalIsValid() is redundant.
      
    if (( !PortalIsValid(portal)) || portal->cleanup == NULL)

should do it, no?

cheers

andrew

In response to

Responses

pgsql-hackers by date

Next:From: Heikki LinnakangasDate: 2009-12-30 13:26:19
Subject: Re: Backup history file should be replicated in Streaming Replication?
Previous:From: Tatsuo IshiiDate: 2009-12-30 12:46:35
Subject: Re: exec_execute_message crash

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group