Skip site navigation (1) Skip section navigation (2)

Re: [PATCH] Provide rowcount for utility SELECTs

From: Boszormenyi Zoltan <zb(at)cybertec(dot)at>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Hans-Juergen Schoenig <hs(at)cybertec(dot)at>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Provide rowcount for utility SELECTs
Date: 2009-12-28 18:29:01
Message-ID: 4B38F8ED.4030403@cybertec.at (view raw or flat)
Thread:
Lists: pgsql-hackers
Tom Lane írta:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
>   
>> On mĂĽn, 2009-12-28 at 11:08 -0500, Tom Lane wrote:
>>     
>>> And, by the same token, the scope for possibly breaking clients is nearly
>>> unlimited ...
>>>       
>
>   
>> Why is that?  Are there programs out there that expect PQcmdTuples() to
>> return something that is *not* the tuple count for these commands and
>> will violently misbehave otherwise?
>>     
>
> It's more the possibility of doing strcmp(tag, "SELECT") on the command
>   

Actually it's strncmp(tag, "SELECT ", 7), so when you mix old server
with new clients or new server with old client, it will just work as
before, i.e.
return "".

> tag that worries me.  Describing the API change here as being limited
> to PQcmdTuples misses the point rather completely: this is a protocol
> change, and could break both clients and non-libpq driver libraries.
>
> 			regards, tom lane
>
>   


-- 
Bible has answers for everything. Proof:
"But let your communication be, Yea, yea; Nay, nay: for whatsoever is more
than these cometh of evil." (Matthew 5:37) - basics of digital technology.
"May your kingdom come" - superficial description of plate tectonics

----------------------------------
Zoltán Böszörményi
Cybertec Schönig & Schönig GmbH
http://www.postgresql.at/


In response to

Responses

pgsql-hackers by date

Next:From: Robert HaasDate: 2009-12-28 19:19:08
Subject: ExecTidReScan exprCtxt
Previous:From: Kevin GrittnerDate: 2009-12-28 17:54:33
Subject: Serializable implementation

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group