Skip site navigation (1) Skip section navigation (2)

Re: Largeobject Access Controls (r2460)

From: KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
To: Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec>, Greg Smith <greg(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Largeobject Access Controls (r2460)
Date: 2009-12-18 08:44:42
Message-ID: 4B2B40FA.1010902@ak.jp.nec.com (view raw or flat)
Thread:
Lists: pgsql-hackers
(2009/12/18 15:48), Takahiro Itagaki wrote:
> 
> Robert Haas<robertmhaas(at)gmail(dot)com>  wrote:
> 
>> In both cases, I'm lost.  Help?
> 
> They might be contrasted with the comments for myLargeObjectExists.
> Since we use MVCC visibility in loread(), metadata for large object
> also should be visible in MVCC rule.
> 
> If I understand them, they say:
>    * pg_largeobject_aclmask_snapshot requires a snapshot which will be
>      used in loread().
>    * Don't use LargeObjectExists if you need MVCC visibility.

Yes, correct.

>> In acldefault(), there is this comment:
>>    /* Grant SELECT,UPDATE by default, for now */
>> This doesn't seem to match what the code is doing, so I think we
>> should remove it.
> 
> Ah, ACL_NO_RIGHTS is the default.

Oops, it reflects very early phase design, but fixed later.

>> I also notice that dumpBlobComments() is now misnamed, but it seems
>> we've chosen to add a comment mentioning that fact rather than fixing it.
> 
> Hmmm, now it dumps not only comments but also ownership of large objects.
> Should we rename it dumpBlobMetadata() or so?

It seems to me quite natural.

The attached patch fixes them.

Thanks,
-- 
OSS Platform Development Division, NEC
KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>

Attachment: pg_dump-blob-fix-comment.patch
Description: text/x-patch (5.2 KB)

In response to

Responses

pgsql-hackers by date

Next:From: C├ędric VillemainDate: 2009-12-18 10:23:09
Subject: Re: Buffer statistics for pg_stat_statements
Previous:From: Takahiro ItagakiDate: 2009-12-18 08:44:40
Subject: Buffer statistics for pg_stat_statements

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group