Skip site navigation (1) Skip section navigation (2)

Re: Re: BUG #5065: pg_ctl start fails as administrator, with "could not locate matching postgres executable"

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Jesse Morris <jmorris(at)coverity(dot)com>, pgsql-bugs(at)postgresql(dot)org, Magnus Hagander <magnus(at)hagander(dot)net>
Subject: Re: Re: BUG #5065: pg_ctl start fails as administrator, with "could not locate matching postgres executable"
Date: 2009-10-19 18:03:14
Message-ID: 4ADCA9E2.4010008@dunslane.net (view raw or flat)
Thread:
Lists: pgsql-bugspgsql-hackers

Dave Page wrote:
> On Fri, Oct 16, 2009 at 7:03 PM, Jesse Morris <jmorris(at)coverity(dot)com> wrote:
>   
>>> -----Original Message-----
>>> From: Dave Page [mailto:dpage(at)pgadmin(dot)org]
>>> Sent: Friday, October 16, 2009 2:14 AM
>>> To: Jesse Morris
>>> Cc: pgsql-bugs(at)postgresql(dot)org
>>> Subject: Re: [BUGS] Re: BUG #5065: pg_ctl start fails as
>>>       
>> administrator,
>>     
>>> with "could not locate matching postgres executable"
>>>
>>>       
>>>> The patch:
>>>>
>>>> ------begin patch------
>>>>         
>>> :-(. Unfortunately inlining the patch in the email has munged it
>>> beyond usability. Can you resend it as an attachment please?
>>>       
>> Oops!  Re-sent, as an attachment.
>>     
>
> Thanks. I've had a play with this, and it seems to work fine in 8.4.1
> - at least, it doesn't seem to cause any regression that I can see
> when testing in Vista or XP. I cannot reproduce the problem since I
> wrote the original fix though, so I cannot confirm that this fixes any
> new cases; we'll have to take your word for that :-)
>
> The code around this has changed a little on -head. I don't have any
> more spare cycles at the moment - are you able to produce an updated
> patch for 8.5?
>
> Andrew/Magnus; we do still see occasional failures of this nature, so
> I believe there is still an issue here. Can we look at getting this
> backpatched for 8.3.whatever and 8.4.2, assuming it looks good to you
> as well?
>
>   

It looks OK to me (modulo the incorrect changing of "its" to "it's" in a 
comment - whoever did that was trying to make it consistent, but 
unfortunately made it consistently wrong).

However, I'd like a bit more comment added on just why doing this is 
safe. Would it still be safe if someone granted some dangerous privilege 
directly to the Administrator user, if that's possible?

cheers

andrew

In response to

Responses

pgsql-hackers by date

Next:From: Kevin GrittnerDate: 2009-10-19 18:07:01
Subject: Re: Controlling changes in plpgsql variable resolution
Previous:From: Robert HaasDate: 2009-10-19 17:56:54
Subject: Re: Controlling changes in plpgsql variable resolution

pgsql-bugs by date

Next:From: steffen nielsenDate: 2009-10-19 21:04:16
Subject:
Previous:From: Dave PageDate: 2009-10-19 13:49:03
Subject: Re: Re: BUG #5065: pg_ctl start fails as administrator, with "could not locate matching postgres executable"

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group