Skip site navigation (1) Skip section navigation (2)

Re: [PATCH] DefaultACLs

From: Jan Urbański <wulczer(at)wulczer(dot)org>
To: Petr Jelinek <pjmodos(at)pjmodos(dot)net>
Cc: Josh Berkus <josh(at)agliodbs(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] DefaultACLs
Date: 2009-09-24 09:29:53
Message-ID: 4ABB3C11.6010005@wulczer.org (view raw or flat)
Thread:
Lists: pgsql-hackers
Petr Jelinek wrote:
> I made some more small adjustments - mainly renaming stuff after Tom's
> comment on anonymous code blocks patch and removed one unused shared
> dependency.

Hi,

the patch still has some issues with dependency handling:

postgres=# create role test;
CREATE ROLE
postgres=# create role test2;
CREATE ROLE
postgres=# create schema s;
CREATE SCHEMA
postgres=# alter default privileges in schema s for user test2 grant
insert on table to test;
ALTER DEFAULT PRIVILEGES
postgres=# drop role test2;
DROP ROLE
postgres=# drop schema s;
ERROR:  could not find tuple for default acls 16387
postgres=#

At this moment pg_default_acls is empty and schema s is undroppable... I
got an unexpected server exit after that once, when I executed \ds from
psql, but unfortunately don't have a backtrace (forgot to ulimit -c
unlimited). The next time I tried to provoke that backend crash I
failed: after the "ERROR:  could not find tuple for default acls 16387"
I'm only stuck with an undroppable schema, but the rest of the system
works normally.

Apart from that all my complains from the previous review seem to be
addressed, except for the tab completion... Not sure if it's mandatory
for commit, but it sure would be useful.

Marking as "Waiting on Author".

Cheers,
Jan

In response to

Responses

pgsql-hackers by date

Next:From: Fujii MasaoDate: 2009-09-24 10:25:02
Subject: Re: Streaming Replication patch for CommitFest 2009-09
Previous:From: Hannu KrosingDate: 2009-09-24 09:16:43
Subject: Re: "BEGIN TRANSACTION" and "START TRANSACTION": different error handling

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group