| From: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> |
|---|---|
| To: | Dave Page <dave(dot)page(at)enterprisedb(dot)com> |
| Cc: | Sachin Srivastava <sachin(dot)srivastava(at)enterprisedb(dot)com>, pgadmin-hackers(at)postgresql(dot)org |
| Subject: | Re: pgAdmin and Slony |
| Date: | 2009-09-03 13:37:25 |
| Message-ID: | 4A9FC695.4050501@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Looks good to me..
Though not tested..
I will be able to test it tomorrow.
Dave Page wrote:
> On Thu, Sep 3, 2009 at 2:08 PM, Sachin
> Srivastava<sachin(dot)srivastava(at)enterprisedb(dot)com> wrote:
>> Dave,
>>
>>> - bool dlgRepCluster::SlonyMaximumVersion(wxString series, long minor)
>>>
>>> should be:
>>>
>>> bool dlgRepCluster::SlonyMaximumVersion(const wxString&series, long minor)
>>>
>> Done.
>>> - Just reading the patch, it looks like we never try to load xxid*.sql
>>> any more. That's surely wrong?
>>>
>> Yes. Attached is an updated patch.
>
> Thanks. I've had a quick look, and it looks reasonable to me. Ashesh;
> can you review it as well please?
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | svn | 2009-09-03 15:53:42 | SVN Commit by dpage: r8029 - trunk/pgadmin3 |
| Previous Message | Dave Page | 2009-09-03 13:28:18 | Re: pgAdmin and Slony |